timob-14224: Add system-wide cookie store for httpclient #4549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| @@ -475,6 +480,7 @@ public TiHTTPClient(KrollProxy proxy) | |||
| { | |||
| this.proxy = proxy; | |||
| this.client = getClient(false); | |||
| this.client.setCookieStore(cookieStore); | |||
There was a problem hiding this comment.
Actually getClient() is called in two different functions, so it's not enough just set cookie store here.
Since the cookie store is associated with the client, it is better to set it in getClient() when the http client is created.
| @@ -1265,11 +1273,10 @@ public void progress(int progress) { | |||
| } | |||
|
|
|||
| Log.d(TAG, "Preparing to execute request", Log.DEBUG_MODE); | |||
|
|
|||
There was a problem hiding this comment.
Unnecessary white spaces.
|
Ran the test case. I clicked "Download", then "Abort", and then "Download" again, everything works fine. But when I clicked "Abort" again, it still kept downloading. Seems it can not be aborted the second time. |
|
FR passed. Code reviewed and left a minor comment. |
|
CR & FR passed. Accepted |
pingwang2011
added a commit
that referenced
this pull request
Aug 23, 2013
timob-14224: Add system-wide cookie store for httpclient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing steps in JIRA.