timob-14791: Disable FastDev on device.

[hieupham007]

testing steps in JIRA.

[ayeung]

This is not a reliable fix to disable fastdev for device. What if there is an emulator that doesn't have 'generic' in either the fingerprint or brand. This also won't work if the device manufacturer somehow put 'generic' as well.

A better way is to just disable it from our build scripts since we have full control over them. You can probably do this by always disabling fastdev when the deploy-type is not 'development' here:
https://github.com/appcelerator/titanium_mobile/blob/master/support/android/builder.py#L2214
and also prevent it from being inserted into the appinfo generated java file here:
https://github.com/appcelerator/titanium_mobile/blob/master/support/android/android.py#L132

[hieupham007]

We could be running device on 'development' mode. I think the sure way of fixing this would be for Studio to give us some sort of flag indicating that the user is launching from device. We can then use this flag to disable fastdev.

[ayeung]

You can't set the deploy-type in the build scripts, so there is no way for you to deploy with 'development' on device. This is internally used in the build scripts. The deploy types are set to:

'development' -> emulator
'test' -> device

CLI does have a --deploy-type flag, but it does nothing since the current build scripts don't support it.

[hieupham007]

Closing PR.