TIMOB-7401 Android: Implement switchCamera #4566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: android/modules/media/src/java/ti/modules/titanium/media/MediaModule.java android/modules/media/src/java/ti/modules/titanium/media/TiCameraActivity.java
TIMOB-7401
ghost
assigned 
| @@ -387,6 +426,29 @@ public void onAutoFocus(boolean success, Camera camera) | |||
| } | |||
| } | |||
|
|
|||
| @SuppressWarnings({ "unchecked", "rawtypes" }) | |||
| public HashMap getOptions() | |||
|
FR looks good so far. Waiting for comments to be addressed. |
TIMOB-7401
|
@ayeung that function wasn't used. I went ahead and removed it. Ready for re-review. |
|
Code reviewed and functionally tested. Request Accepted. |
ayeung
pushed a commit
that referenced
this pull request
Aug 20, 2013
TIMOB-7401 Android: Implement switchCamera
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JIRA for testing notes.