[TIMOB-15021] adding ActionBar support library to enable ActionBar on all Android versions #4591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Mark, did you get any further with this? |
|
Nope, see my comments here: https://jira.appcelerator.org/browse/TIMOB-15021 |
|
Mark, thank you very much for your contribution. We've reused some of your code to integrate AppCompat to Titanium. Please see https://jira.appcelerator.org/browse/TIMOB-15021 for more details. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the new Android Support Library to enable ActionBar across the board.
See http://www.youtube.com/watch?v=6TGgYqfJnyc for general info on this.
The submitted pull request builds cleanly, however it currently doesn't pass testing since the required Theme.AppCompat... in the test app's AndroidManifest.xml is not found by Studio. Google's instructions for applying a support library with resources (see http://developer.android.com/tools/support-library/setup.html ) don't directly apply to Titanium SDK development, and I am not expert enough on Titanium Android build integration to fix that step. Hopefully someone with knowledge of this process can at least perform that step - this support library would be a huge improvement!
To test: (currently fails)