[TC-2812] Update the closure-compiler from a two-year-old version to the current 2...

[tijszwinkels]

...0130722 release. Resolves ticket #TC-2812: "Python error (TypeError: not all arguments converted during string formatting) when building package for App Store"

[cb1kenobi]

@tijszwinkels Thank you for the updated file, however we are in the process of migrating from Closure Compiler to UglifyJS, so there won't be a need to update Closure Compiler.

[tijszwinkels]

Depending on the time-frame for migration to UglifyJS, I can see how you wouldn't want to increase the repository size with 6M for 'all eternity' if the bug is going to be fixed soon anyway.

However:

• This bug seems pretty prevalent to me, at least for applications written in Coffeescript. I've seen this error crop up in multiple places over the last few months, but it's hard to report or debug since it just seems to be crashing in an internal python-script.
• Instead, could you merge Fixes TC-2813 - "Whenever compiler.py encounters an 'unrecognized error'... #4603 as a stop-gap until the migration is complete? It's minimally invasive, and at least it allows users to debug their problem. (And possibly manually replace the closure-compiler, as I did)

[cb1kenobi]

@tijszwinkels The "master" branch will be our next major release and will include the switch from Closure Compiler to UglifyJS. There's no point in merging this PR if we're going to rip out the Closure Compiler.

However, we may do another 3.1.X release in which case this PR is totally valid, but you'd need to issue the PR against the "3_1_X" branch instead of "master".

[tijszwinkels]

@cb1kenobi That make a lot of sense. Thanks for clarifying about the master branch.