Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-14396] Tab icon/activeIcon Fixes #4607

Merged
merged 5 commits into from Aug 28, 2013
Merged

[TIMOB-14396] Tab icon/activeIcon Fixes #4607

merged 5 commits into from Aug 28, 2013

Conversation

vishalduggal
Copy link
Contributor

PR for TIMOB-14936

Test is in JIRA

  1. New property on tabGroup - tabsTintColor
  2. icon and activeIcon can now be specified to be rendered in original or template mode on IOS7+. Properties iconIsTemplate, activeIconIsTemplate. Default - true

Known Issue:

  1. On IOS7+ activeTabIconTint property of tabGroup is not being honored. No idea why. tabsTintColor seems to work better (though it tints the title as well and works on active tab only though the docs say it should apply to all tabs.)

Docs will be updated along with the windowRefactor doc PR.

@ghost ghost assigned srahim Aug 27, 2013
@srahim
Copy link
Contributor

srahim commented Aug 27, 2013

This is a very minor quibble. The API name iconisTemplate/ activeiconIsTemplate sounds confusing. I know its what Apple calls it too. People might get confused as to what template means. Does iconMask, activeiconMask sound any better ?

Apart from that minor problem. Everything looks good. Code looks good.

@srahim
Copy link
Contributor

srahim commented Aug 27, 2013

Functionally Tested and APPROVED

@srahim
Copy link
Contributor

srahim commented Aug 27, 2013

Waiting for feedback from Vishal to process this PR.

@srahim
Copy link
Contributor

srahim commented Aug 28, 2013

Code Looks good. APPROVED

srahim added a commit that referenced this pull request Aug 28, 2013
[TIMOB-14396] Tab icon/activeIcon Fixes
@srahim srahim merged commit 0a218b5 into tidev:master Aug 28, 2013
@vishalduggal vishalduggal deleted the timob-14936 branch October 27, 2014 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants