timob-14520: Android: Anvil: android/android/android -> jsActivityUrl failed #4622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Hold off and do not merge. This might possibly reintroduce the dead lock crash we saw when the launchActivity tried to fire the create sync event. |
… block the UI thread to get ANR.
| * Sends a message to an {@link java.util.concurrent.ArrayBlockingQueue#ArrayBlockingQueue(int) ArrayBlockingQueue}, | ||
| * and dispatch messages on the current | ||
| * queue while blocking on the passed in AsyncResult. The blocking is done on the KrollRuntime thread. | ||
| * If maxTimeout > 0 and the cannot get the permission from the semaphore within maxTimeout, throw an error and return. |
There was a problem hiding this comment.
"the" doesn't make sense here. Typo?
|
Code reviewed. Please address comments. |
|
Updated. |
|
Code reviewed and functionally tested. Request accepted |
hieupham007
added a commit
that referenced
this pull request
Sep 14, 2013
timob-14520: Android: Anvil: android/android/android -> jsActivityUrl failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-14520