TIMOB-14746-added support for appCache #4661
Conversation
| @@ -147,6 +147,11 @@ public TiUIWebView(TiViewProxy proxy) | |||
| settings.setDatabaseEnabled(true); | |||
| } | |||
|
|
|||
| File cacheDir = TiApplication.getInstance().getCacheDir(); | |||
| if (cacheDir != null) { | |||
| settings.setAppCacheEnabled(true); | |||
There was a problem hiding this comment.
I'm not sure if this addresses the issue mentioned. The ticket specifically ask for caching using a custom manifest, i.e: only cache the files declared in the manifest. Essentially we would need to implement our own custom cache.
There was a problem hiding this comment.
The manifest file is deployed in the server describing which files can be cached and is referred in the html file using 'manifest' attribute in the html tag. The client webview will only cache those files, I don't think we need to do anything else. I tested with 'http://www.w3schools.com/html/tryhtml5_html_manifest.htm' and seems working.
|
Ran the test case. When I went to step 3, the webview shows "Webpage not available: the webpage at [my local host] might be temporarily down ....". Can you confirm the testing steps in the ticket? |
|
Did you set up the server with right html and the manifest files? |
|
I followed "Test case" and "Test code" in the ticket description. If you used some other test case, can you put all your code and testing steps in the ticket? |
ghost
assigned
|
Added comment with test case to use an existing server url that is already setup for html5 caching. |
|
Code reviewed and functionally tested. Accepted |
TIMOB-14746-added support for appCache
Added support for appCache
https://jira.appcelerator.org/browse/TIMOB-14746