New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TIMOB-12539 added a new property calendarViewShown #4667
TIMOB-12539 added a new property calendarViewShown #4667
Conversation
Please add documentation to this new property |
ok |
Did you update the documentation? I didn't see any new commits. |
document updated |
@@ -72,6 +75,9 @@ public void processProperties(KrollDict d) { | |||
|
|||
this.minDate = minDateCalendar.getTime(); | |||
} | |||
if (d.containsKey(TiC.PROPERTY_CALENDAR_VIEW_SHOWN)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation is off for this clause
code reviewed and functionally tested. Request accepted |
TIMOB-12539 added a new property calendarViewShown
@@ -318,6 +318,15 @@ properties: | |||
type: Number | |||
default: 5 | |||
platforms: [android] | |||
|
|||
- name: calendarViewShown |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is not properly aligned. It needs to be moved back two spaces. It is currently breaking the documentation build script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies. I will send a new PR to fix this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://jira.appcelerator.org/browse/TIMOB-12539