[TIMOB-15116]iOS: Adding support for 64 bit iOS7 4-inch simulator. #4673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -80,6 +80,9 @@ exports.init = function (logger, config, cli) { | |||
| cmd.push('--retina'); | |||
| if (appc.version.gte(build.iosSimVersion, '6.0.0') && build.iosSimType == 'iphone' && cli.argv.tall) { | |||
| cmd.push('--tall'); | |||
| if (appc.version.gte(build.iosSimVersion, '7.0.0') && build.iosSimType == 'iphone' && cli.argv.tall) { | |||
There was a problem hiding this comment.
Won't this always launch the 64bit simulator if you say retina and tall? Is that the expected behavior?
I think this should be cli.argv.sim-64bit
|
CR failed. As expected FR also failed. |
|
CR and FR ok. Able to launch 64 bit and non 64 bit sim on iOS7. 64 bit sim parameter ignored on lower versions. APPROVED |
vishalduggal
added a commit
that referenced
this pull request
Sep 13, 2013
[TIMOB-15116]iOS: Adding support for 64 bit iOS7 4-inch simulator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TESTING INSTRUCTIONS
Code Review of the ios-sim project to be done on https://github.com/appcelerator/ios-sim/pull/5
the testing can be done only through CLI.
Make sure when you are building through scons you do "node-appc-branch=master"
Make sure to kill the simulator before running the next command. Otherwise the right simulator will not be displayed