[TIMOB-15205] 3_1_X iOS7 : Fire change event when there is actually a change in value. #4696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…though there was no change in value.
|
|
||
| //No need to setValue, because it's already been set. | ||
| if ([self.proxy _hasListeners:@"change"]) | ||
| if ([self.proxy _hasListeners:@"change"] && (current != newValue) ) |
There was a problem hiding this comment.
While NSNumber bools will be constants and this will work fine, this is technically inaccurate. i.e., this should be:
&& (current != newValue) && ![current isEqual:newValue]
The pointer compare is for nil vs nil. The isEqual is for different objects holding the same value.
|
CR accepted, FR passed. Merging. |
WhichKatieDid
added a commit
that referenced
this pull request
Sep 16, 2013
[TIMOB-15205] 3_1_X iOS7 : Fire change event when there is actually a change in value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing instruction in JIRA
backport of #4695