timob-14359: Android: First TableViewRow is cut off #4708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| @@ -478,7 +478,8 @@ protected void onMeasure(int widthMeasureSpec, int heightMeasureSpec) | |||
|
|
|||
| // If there is a child view, we don't set a minimum height for the row. | |||
| // Otherwise, we set a minimum height. | |||
| if (((TableViewRowProxy) item.proxy).hasControls()) { | |||
| boolean hasChildView = ((TableViewRowProxy) item.proxy).hasControls(); | |||
| if (hasChildView) { | |||
| content.setMinimumHeight(0); | |||
| } else { | |||
| content.setMinimumHeight(48); | |||
There was a problem hiding this comment.
please also take this opportunity to move '48' out as a constant.
|
Code reviewed. Please address comments. |
|
Updated. Ready for review. |
|
Code reviewed and functionally tested. Requsst accepted |
hieupham007
added a commit
that referenced
this pull request
Oct 2, 2013
timob-14359: Android: First TableViewRow is cut off
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-14359