[TIMOB-15284] Fix Set Status Bar Style #4709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No API existed to dynamically change the status bar style on iOS.
|
@dawsontoth Thanks for providing this. It seems different enough as new functionality that I'd like to call it out specially. Would you mind creating a ticket and a test case and attaching this PR to that, please? |
| default: | ||
| barStyle = UIStatusBarStyleDefault; | ||
| } | ||
| [[TiApp controller] updateStatusBar]; |
There was a problem hiding this comment.
if(focussed) {
TiThreadPerformOnMainThread(^{
[[[TiApp app] controller] updateStatusBar];
}, YES);
}
|
Code Reviewed. Please address comments |
|
@vishalduggal done. |
|
CR and Fr ok. APPROVED |
vishalduggal
added a commit
that referenced
this pull request
Oct 8, 2013
[TIMOB-15284] Fix Set Status Bar Style
|
This does not work for a Window within a NavigationWindow on 3.2.0GA. The Navigation window will change, but the Window within will not change unless a modal window is displayed then closed. (there may be other events that force a UI update as well, but this is the only I've found.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No API existed to dynamically change the status bar style on iOS.
https://jira.appcelerator.org/browse/TIMOB-15284