Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS Backports for ListView and TableView (merge-3.1.4) #4722

Merged
merged 13 commits into from Sep 26, 2013
Merged

IOS Backports for ListView and TableView (merge-3.1.4) #4722

merged 13 commits into from Sep 26, 2013

Conversation

vishalduggal
Copy link
Contributor

Fixes
TIMOB-15278
TIMOB-15291
TIMOB-15282
TIMOB-15281
TIMOB-14888
TIMOB-15204
TIMOB-15272
TIMOB-14309

Regress against
TIMOB-13237
TIMOB-5354
KS->Animations
KS->TableView

Use app.js attached to TIMOB-14888 for testing

@ghost ghost assigned srahim Sep 20, 2013
@srahim
Copy link
Contributor

srahim commented Sep 20, 2013

FR failed for TIMOB-15291 . Seeing white cells with no text. are we missing any related commits ??

@vishalduggal
Copy link
Contributor Author

Fixed. Missed a change during conflict resolution. Ready for review

@srahim
Copy link
Contributor

srahim commented Sep 23, 2013

Code Reviewed and approved

Functionally tested and APPROVED

@srahim
Copy link
Contributor

srahim commented Sep 23, 2013

holding off on merging till vishal gives the go ahead.

@srahim
Copy link
Contributor

srahim commented Sep 26, 2013

Code Re-reviewed . the diff's match up as expected.

@srahim
Copy link
Contributor

srahim commented Sep 26, 2013

Functionally Tested and approved

srahim added a commit that referenced this pull request Sep 26, 2013
IOS Backports for ListView and TableView (merge-3.1.4)
@srahim srahim merged commit baf9108 into tidev:3_1_X Sep 26, 2013
@vishalduggal vishalduggal deleted the listview_tableview_backports branch October 27, 2014 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants