Updated tiapp.xml for deprecated elements

[FokkeZB]

Now conform http://docs.appcelerator.com/titanium/latest/#!/guide/tiapp.xml_and_timodule.xml_Reference

JIRA: https://jira.appcelerator.org/browse/TIMOB-14620

[cb1kenobi]

Code reviewed and looks good!

[FokkeZB]

If it was up to me I'd also add "dp" as the default unit as well as some other sensible defaults like the android restart bug workaround.

[cb1kenobi]

@FokkeZB Dumb question, but does iOS support "dp" or is it "dip" or both? I'm definitely open to hear what other defaults you think should be set. I have a soft spot for sensible defaults. :)

[FokkeZB]

According to http://docs.appcelerator.com/titanium/latest/#!/guide/Transitioning_to_the_New_UI_Layout_System-section-30088148_TransitioningtotheNewUILayoutSystem-UniversalUnitSupport you can use either dp or dip. For iOS it's the system default, but on Android it's px. I always set it to dp, since using android:anyDensity is discouraged.

[FokkeZB]

I've added two defaults I always set.

I also always set <navbar-hidden>true</navbar-hidden> to hide the titlebar on the Android plash screen, but I don't know if that has unwanted side effects. I mainly do custom UI's, but it might impact default UI's.

[cb1kenobi]

@FokkeZB I sent an email out to the entire team and it seems all the professional services guys always set the default the unit to "dp". They didn't think we should change the default orientation settings for iOS (I was just curious if what we have now makes sense). will have no effect in Titanium SDK 3.1.3 (or newer) on iOS 7, so it may make sense to change the default value from false to true, but we haven't fully understood the side effects. I'm still waiting for more feedback.

[FokkeZB]

I left the deprecated settings that now fall under <ios> in, but the values are also the defaults, so we might also consider just leaving them out.

[cb1kenobi]

We just had a meeting and we agree that the default unit should be dp.

We decided to NOT set <property name="ti.android.bug2373.finishfalseroot" type="bool">true</property> by default. This was to overcome an Android bug when launching the app the first time. I'm not certain how big of an issue this is, especially on newer Android SDKs.

The <iphone> section will be replaced by <ios> as your pull request has done.

Furthermore, we will want to add UIInterfaceOrientationLandscapeLeft and UIInterfaceOrientationLandscapeRight to the default iPhone orientations since that's what Apple's Human Interface Guidelines recommend.

We're still researching the side effects of changing <navbar-hidden> to true.

We will want to update all of our samples (downloaded from Studio) to use these new best practices.

[cb1kenobi]

@FokkeZB This PR looks good except we have decided to not change the default ti.android.bug2373.finishfalseroot value for new projects. Due to time constraints, I've just fixed it in a separate PR: #4973.

[FokkeZB]

Good to see its fixed, unfortunate you couldn't use my PR ;)

And why will ti.android.bug2373.finishfalseroot not be changed?

[cb1kenobi]

Great question! I have no idea. I know they changed the behavior in the Android code today. Not sure what. Check it out here: https://jira.appcelerator.org/browse/TIMOB-15484.

[FokkeZB]

Yeah, I just saw the default is now set in the code, so it doesn't matter having it in tiapp.xml:

https://github.com/appcelerator/titanium_mobile/pull/4975/files

[ingo]

We decided it was better to update the default behavior than force it into the tiapp.xml.