TIMOB-14395-if height or width not defined, set those keeping aspect rat... #4738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // so that it doesn't get the content height/width | ||
| if (!viewWidthDefined || !viewHeightDefined) { | ||
| Drawable d = imageView.getDrawable(); | ||
| float aspectRaio = 1; |
|
You said the documentation is incorrect, are you going to fix it in this PR? |
|
Code reviewed and functionally tested. Looks good, just a couple minor comments |
|
The documentation is at http://docs.appcelerator.com/titanium/latest/#!/guide/Images_and_ImageView_APIs |
|
That is the guides, and I don't think its in our repo. Will talk to Ben on Monday. Merging this |
hieupham007
added a commit
that referenced
this pull request
Oct 13, 2013
TIMOB-14395-if height or width not defined, set those keeping aspect rat...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test case is working correctly. If both width and height is defined, the image will scale to fill the area without maintaining the aspect ration. The documentation is not correct.
The test case in the comment should make the image scale keeping the aspect ratio intact and keeping the width.
Code change fix this issue
https://jira.appcelerator.org/browse/TIMOB-14395