TIMOB-2849 Android: Set-Cookie Response Headers Only Returns Max of One Cookie

[ayeung]

Added a shared cookie store for TiHTTPClient.

For testing: use the original app.js snippet from the bug description. To test the persistent cookiestore functionality do the following:

1. Launch the app.js in the bug description
2. Click on Get or Set Cookies (it should list 2 cookies that were set)
3. Close and relaunch the app
4. Click on clear cookies
5. Verify that it says something like "Set 2 cookies to expire a year ago"

[donthorp]

Please update Copyright to 2011

[donthorp]

Code Reviewed. Request Accepted

[billdawson]

I think this needs to be simplified. TiCookieStore is only needed once in the application. It should be a singleton with a .getInstance() like TiApplication.getInstance(). Nothing needs to go into the NetworkModule.

When the singleton TiCookieStore needs a context for .getSharedPreferences(), it can just use the TiApplication's context.

[billdawson]

The manner in which the SharedPreferences store is being used here seems inefficient to me (or I'm missing something.) SharedPreferences is already a key-value store, yet you're forcing all cookie keys to be concatenated together into one preferences key. You already have a store ("TiCookiePreferences") dedicated to just cookies, so why not let the keys of that store be cookie keys, and the values of that store be cookie values?

[ayeung]

I currently have one preference that contains the list of all the cookies keys that are stored in preferences and then for each cookie, I use the cookie key for the preference key, and the cookie value for the value. I need to store the list of all the cookie keys in one preference key, since I don't have a way of knowing the which cookies are in preferences at startup. At startup, I iterate through the list of all cookie keys to populate the cookiestore.

[billdawson]

I'm pretty sure there's a way to get the cookie keys (the keys in the preferences) at startup without storing them all in one. Check the SharedPreferences documentation -- there's some method that gives you everything back as a Map, and then from the Map object you can get keys. (If I remember correctly.) That way we can avoid these string operations like splitting by comma, concatenating, etc.

[billdawson]

Functional test and code review accepted. w00t!

Don needs to re-code-rev.

[donthorp]

Code Reviewed. Request Accepted.