Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timob 13686 v1: Listview headerView, footerView, canScroll, separatorColor #4747

Merged
merged 10 commits into from Oct 4, 2013

Conversation

hieupham007
Copy link
Contributor

Testing steps in JIRA

@pingwang2011
Copy link
Contributor

Ran the modified test case in my comment https://jira.appcelerator.org/browse/TIMOB-13686?focusedCommentId=273282&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-273282 . When canScroll is set to true, the touchCancel gesture (touch one label and move out of the label and then release) won't fire "itemclick" event. But when canScroll is set to false, the touchCancel gesture will fire "itemclick" event.

@hieupham007
Copy link
Contributor Author

yes this is expected behavior. 'canscroll' is implemented by ignoring ACTION_MOVE gestures. This will apply to listview and its contents.

@pingwang2011
Copy link
Contributor

Is this behavior the same as on iOS? Will that be a potential parity issue?

@ghost ghost assigned pingwang2011 Oct 1, 2013
@pingwang2011
Copy link
Contributor

Ran this test case https://jira.appcelerator.org/browse/TIMOB-13686?focusedCommentId=273282&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-273701 to change the headerView of the section. Click the button "change me" and then the app crashes.

@pingwang2011
Copy link
Contributor

The same thread issue for changing headerTitle and footerTitle of the section. Please fix it.

@pingwang2011
Copy link
Contributor

Code reviewed and functionally tested. Accepted

pingwang2011 added a commit that referenced this pull request Oct 4, 2013
Timob 13686 v1: Listview headerView, footerView, canScroll, separatorColor
@pingwang2011 pingwang2011 merged commit 1bff05e into tidev:master Oct 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants