New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timob 13686 v1: Listview headerView, footerView, canScroll, separatorColor #4747
Conversation
Ran the modified test case in my comment https://jira.appcelerator.org/browse/TIMOB-13686?focusedCommentId=273282&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-273282 . When canScroll is set to true, the touchCancel gesture (touch one label and move out of the label and then release) won't fire "itemclick" event. But when canScroll is set to false, the touchCancel gesture will fire "itemclick" event. |
yes this is expected behavior. 'canscroll' is implemented by ignoring ACTION_MOVE gestures. This will apply to listview and its contents. |
Is this behavior the same as on iOS? Will that be a potential parity issue? |
Ran this test case https://jira.appcelerator.org/browse/TIMOB-13686?focusedCommentId=273282&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-273701 to change the headerView of the section. Click the button "change me" and then the app crashes. |
The same thread issue for changing headerTitle and footerTitle of the section. Please fix it. |
Code reviewed and functionally tested. Accepted |
Timob 13686 v1: Listview headerView, footerView, canScroll, separatorColor
Testing steps in JIRA