[TIMOB-13610] correctly handle scrollableView inside tableview/listview and scrollview AGAIN #4748
Conversation
Conflicts: android/modules/ui/src/java/ti/modules/titanium/ui/widget/TiUIScrollableView.java
| @@ -100,6 +105,8 @@ public boolean onInterceptTouchEvent(MotionEvent event) { | |||
| @Override | |||
| public void onPageScrollStateChanged(int scrollState) | |||
| { | |||
| mPager.requestDisallowInterceptTouchEvent(state != ViewPager.SCROLL_STATE_IDLE); | |||
There was a problem hiding this comment.
Do you mean "scrollState" here?
|
I am sorry @pingwang2011 the merge did not go well. Will clean all that up! Thanks |
|
@pingwang2011 i have cleaned up the code. Thanks for your comments. Thanks |
| @@ -75,6 +75,7 @@ | |||
| import android.view.Gravity; | |||
| import android.view.View; | |||
| import android.view.View.MeasureSpec; | |||
| import android.view.ViewParent; | |||
|
Ran the three test cases in my comments in JIRA. It works fine for ScrollableView inside ScrollView. It exposes some issues on ScrollableView inside TableView/ListView. Those issues are not caused by this PR. Already filed TIMOB-15408 to follow up. |
|
farfromrefug, you still missed two unnecessary imports. One is line 19 in TiUIScrollableView.java and the other is in TiUIHelper.java. |
|
@pingwang2011 first i want to apologise. My problem is that i cant run those PR branches in my TiStudio. It breaks my metadata folder. I should create another workspace just for that but i dont really have the time right now. I am really sorry! |
|
CR passed. Request Accepted |
[TIMOB-13610] correctly handle scrollableView inside tableview/listview and scrollview AGAIN
test case inside the jira ticket