[TIMOB-6949] table filter does not hide empty headers #4764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Functional test failed: http://pastie.org/private/a2wt8kb1hebvrgutyat7a. 'a-f' and 'b-f' footers didn't show on start up. |
|
This bug not regarding this ticket . I got this bug in master also . Shall I fix this in same ticket or in new ticket ? |
|
I think this is also within the scope of this ticket (headers and footers should display properly). We should probably fix that here. |
|
Looking . update soon |
ghost
assigned 
| @@ -594,6 +594,9 @@ private TableViewSectionProxy addRowToSection(TableViewRowProxy row, TableViewSe | |||
| if (row.hasProperty(TiC.PROPERTY_FOOTER)) { | |||
| addedToSection.setProperty(TiC.PROPERTY_FOOTER_TITLE, row.getProperty(TiC.PROPERTY_FOOTER)); | |||
| } | |||
| if (row.hasProperty(TiC.PROPERTY_TITLE)) { | |||
There was a problem hiding this comment.
this seems unnecessary. Why do we need this here?
|
Code reviewed. Please address comments. |
|
k will update today |
|
create new PR |
|
Closing PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-6949
create new PR