New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anvil testcase for iphone_ui_toolbar test suite #4768
Conversation
] | ||
|
||
//TIMOB-4911 | ||
this.uiDotIOSdotToolbar = function(testRun) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would _
work instead of Dot ? if so , please rename the function.
very minor quibble. Looks all good. @lokeshchdhry if you can manually verify that this test case passes for iOS by putting it general test space and running anvil to verify the test case passes without failure. go ahead and merge it. Let me know if this works out. |
@srahim - I ran them manually in general test space & all passed. Also, putting [ _ ] for this.uiDotIOSdotToolbar works. |
@lokeshchdhry in that case i would make the suggestion for replacing the test case names with _ and you can merge it in. |
@shameer49 - change the test name to "this.ui_IOS_Toolbar" & use [ _ ] rather than a dot from now on. |
@lokeshchdhry @srahim thank you for your feedback. |
@@ -54,7 +54,8 @@ if (Ti.Platform.osname === 'android') { | |||
suites = suites.concat([ | |||
{name: "iphone/iphone_2Dmatrix"}, | |||
{name: "iphone/iphone_ui"}, | |||
{name: "iphone/iphone_UI_3DMatrix"} | |||
{name: "iphone/iphone_UI_3DMatrix"}, | |||
{name: "iphone/iphone_ui_toolbar"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suite already been added to app.js
@srahim @lokeshchdhry suite modified and updated please review. |
Changes verified . Merging. |
Anvil testcase for iphone_ui_toolbar test suite
Testcase:
TIMOB-7830
TIMOB-4911