TIMOB-15314-set the layout params to borderview if view has border #4778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this on 2.2 and 4.2.x devices. On 2.2, it works fine (I can repro the crash). On 4.2.x, I dont see the box anymore after it animates ( I do see the box on 2.2 after it animates). |
|
Are you seeing the same behavior? |
|
Since this was pre Honeycomb, I didn't try it with 4.2. I tried it now and you are right, I don't see the box. Since the code change won't affect 4.2, looks like this was already broken for 4.2. Looks like there are some recent changes in this file specific to HoneyComb and later versions. |
|
Ok, I opened a new ticket for this issue: https://jira.appcelerator.org/browse/TIMOB-15471. Merging this PR |
hieupham007
added a commit
that referenced
this pull request
Oct 13, 2013
TIMOB-15314-set the layout params to borderview if view has border
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the parent is border view, set the layout params to the border view.
https://jira.appcelerator.org/browse/TIMOB-15314