Anvil testcase for ui_label testsuite #4787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| finish(testRun); | ||
| }, 2000); | ||
| } |
There was a problem hiding this comment.
label is never added to the window. The test creates a proxy and reads value back, is that the purpose of the test . If so, why do we need a window ?
|
Left some minor comments, for the most part the PR case looks good. |
|
Code Reviewed and APPROVED REMINDER FOR THE FUTURE : tickets that throw console log errors or warning cannot be checked in anvil. @lokeshchdhry if the test cases passes in anvil for both iOS and Android. Please go ahead and merge it in. |
lokeshchdhry
pushed a commit
that referenced
this pull request
Nov 11, 2013
Anvil testcase for ui_label testsuite
|
Tests passed for both ios & android . Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anvil testcase for ui_label
TESTCASES:
TIMOB-9912
TIMOB-9994
TIMOB-8955
TIMOB-8246
TIMOB-4123