New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TiMOB-14624] iOS - TransitionAnimation for NavigationWindow and Tab #4791
Conversation
Conflicts: iphone/iphone/Titanium.xcodeproj/project.pbxproj
-(void)setTransitionTo:(id)args | ||
{ | ||
RELEASE_TO_NIL(_transitionTo) | ||
_transitionTo = [TiAnimation animationFromArg:args context:[self executionContext] create:YES]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we force creating the animation?
Also added transition animation to the "more" tab in the tabgroup
Code Reviewed. ACCEPTED |
|
||
-(void)setTransitionAnimation:(id)args | ||
{ | ||
ENSURE_SINGLE_ARG(args, TiUIiOSTransitionAnimationProxy) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One Minor Fix ENSURE_SINGLE_ARG_OR_NIL
FR Passed. Works well with NavWindow and TabGroups.Will merge once comment is addressed. |
APPROVED. Merging |
[TiMOB-14624] iOS - TransitionAnimation for NavigationWindow and Tab
No description provided.