Timob 15244: Android: expose the cookie management methods for HTTPClient and WebView #4804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| return; | ||
| } | ||
|
|
||
| super.onPropertyChanged(name, value); |
There was a problem hiding this comment.
this should be called in the else case at the end of this method
There was a problem hiding this comment.
It can not be in the else case. Because in the KrollProxy.onPropertyChanged(), it calls properties.put(name, newValue). That's where the property value get updated.
|
Reviewed. Ran validate and deploy scripts. Left a few comments. |
| public CookieProxy[] getHTTPCookiesForDomain(String domain) | ||
| { | ||
| if (domain == null || domain.length() == 0) { | ||
| Log.e(TAG, "Unable to get the HTTP cookies. Need to provide a valid domain."); |
There was a problem hiding this comment.
This should probably only show in debug mode.
|
Code reviewed. Please address comments. |
|
Updated. Ready for review. |
|
Code reviewed and functionally tested. Ran all test cases in ticket + anvil. Request accepted |
hieupham007
added a commit
that referenced
this pull request
Oct 23, 2013
Timob 15244: Android: expose the cookie management methods for HTTPClient and WebView
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-15244