timob-15515: Android: Add support for shadowOffset, shadowColor and shadowRadius on Label & Button #4811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Label and Button
ghost
assigned 
| - name: shadowRadius | ||
| summary: Radius of the shadow. | ||
| type: Number | ||
| default: 0 |
There was a problem hiding this comment.
The default isn't 0 with this PR. The default is 'undefined'. To make default 0, you need to add it to defaultValues map, either in proxy's constructor, or in handleCreationArgs().
|
Code reviewed. Please address comments. |
| /** | ||
| * @module.api | ||
| */ | ||
| public static final String PROPERTY_SHADOW_COLOR = "shadowColor"; |
There was a problem hiding this comment.
this should place before shadow_offset :)
|
Reviewed. Ran validate and docgen. Left two comments. |
|
Updated. Ready for review. |
|
Code reviewed and functionally tested. Request accepted. Waiting for doc's approval |
|
DR approved. |
hieupham007
added a commit
that referenced
this pull request
Oct 22, 2013
timob-15515: Android: Add support for shadowOffset, shadowColor and shadowRadius on Label & Button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-15515