TIMOB-15535: Don't default to setting textareas to InputType.TYPE_TEXT_FLAG_IME_MULTI_LINE. #4825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…T_FLAG_IME_MULTI_LINE.
ghost
assigned 
|
Looking at the code, this sample wouldn't work: http://pastie.org/private/jmjygzijih60gch7ngdq, since changing the returnKeyType will overwrite the current inputType with IME_MULTI_LINE. This behavior is also a regression caused by the same PR. Please let me know if you're going to fix it with this PR. Otherwise looks good. |
…te the returnKeyType.
|
Good catch. I've updated it so we also update the keyboard when we change the returnKeyType. |
|
Code reviewed and functionally tested. Request accepted |
hieupham007
added a commit
that referenced
this pull request
Oct 30, 2013
TIMOB-15535: Don't default to setting textareas to InputType.TYPE_TEXT_FLAG_IME_MULTI_LINE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-15535
Test case in Jira. As a part of this PR, please test against the original bug that caused this:
https://jira.appcelerator.org/browse/TIMOB-14615