timob-14218: Android: Implement apiName constants #4826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| summary: The name of the API that this proxy corresponds to. | ||
| description: | | ||
| The value of this property is the fully qualified name of the API. For example, a [Button](Titanium.UI.Button) | ||
| will return "Ti.UI.Button" for apiName. |
There was a problem hiding this comment.
Change last sentence to:
For example, Button returns Ti.UI.Button.
|
Reviewed. Ran validate and docgen. Left one comment. |
| returns `Ti.UI.Button`. | ||
| permission: read-only | ||
| type: String | ||
| platforms: [android, blackberry, iphone, ipad] |
There was a problem hiding this comment.
this is already implemented on blackberry and ios?
There was a problem hiding this comment.
Yes. Checked the subtasks https://jira.appcelerator.org/browse/TIMOB-12553. Actually it's also done on MW and Tizen. Will update the doc.
|
Code reviewed and functionally tested. Request accepted |
hieupham007
added a commit
that referenced
this pull request
Oct 23, 2013
timob-14218: Android: Implement apiName constants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-14218