Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-15211] remove settype from intent and changed ACTION_SEND to ACTION_SENDTO #4849

Conversation

bijupmb
Copy link
Contributor

@bijupmb bijupmb commented Oct 25, 2013

@hieupham007
Copy link
Contributor

Functional failed. Gmail crashed with this error http://pastie.org/private/a7p3tzbmrnwotx3tz42nuw on 4.2.x device.

@ghost ghost assigned hieupham007 Dec 11, 2013
@hieupham007
Copy link
Contributor

Any update on this?

@bijupmb
Copy link
Contributor Author

bijupmb commented Feb 5, 2014

will check it

@bijupmb
Copy link
Contributor Author

bijupmb commented Feb 17, 2014

This work fine for me . I tested this code in 4.1, 4.2 and 4.3 devices

@hieupham007
Copy link
Contributor

Im still getting the crash on 4.2.x device (Samsung Galaxy Nexus). My testing steps is in KitchenSink, Views -> Email Dialog - > Choose a picture -> click on that picture -> crash. On 3.2.1.GA, when I click on the selected picture, it prompts me to choose Gmail or Skype (which is the original bug).

@bijupmb
Copy link
Contributor Author

bijupmb commented Mar 18, 2014

Let me check

@negupta
Copy link
Contributor

negupta commented Apr 17, 2014

@bijupmb There has been no update on this PR for a month now. We should follow up proactively on these PRs.

@salachi
Copy link
Contributor

salachi commented Jul 20, 2014

Hieu,
I integrated this change with latest master and I can see the fix working when I select the image from the 'Gallary' and it shows only the email apps as expected. I tried with Galaxy Note (4.4.2) and Galaxy Nexus (4.3). When I tried with 'Photos', app is crashing but I don't think this is related to the fix. I can reproduce the crash even without the changes using master. I think the issue is with TitaniumBlob getting getNativeFile for the 'Photos' uri.
Let me know if you are seeing a different crash.

@hansemannn
Copy link
Collaborator

Closing this PR, since the CLA is not signed and the functional tests failed on latest SDK's.

@hansemannn hansemannn closed this Mar 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants