TIMOB-5176 TIMOB-5177 Improved scaling of ImageView bitmaps #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing system animations have time to complete.
… is incredibly detailed information on the bug: This bug was difficult to track down, and intermittent, because it relies entirely on where the submodules were situated in JSCore heap blocks. It turns out that JSCore's sweep of unmarked (read: 'unprotected') cells destroys them and then calls a placement new() on them to force the constructor to dump the null/undefined structure into the memory block. But then, for whatever reason, this would not always cause an [undefined] access when querying the submodule a second time, after GC. It appears that there is a second component to detecting bugs like this one, which involves bad bridge interaction (obj-c counts not matching protect counts). It could be the case that we're GCing different heaps at different times, which would be some bad news (too much garbage resident in memory). Short version: If you pull an [undefined] value where a proxy should be, it's because it was unprotected at some point.
…move a 'not used' warning from TiUIView just cuz
|
Request Accepted: |
|
Code reviewed. Functional tested with both JIRA test scripts and KS image tests. Request Accepted. |
|
Code reviewed. Request Accepted. |
donthorp
added a commit
that referenced
this pull request
Sep 26, 2011
TIMOB-5176 TIMOB-5177 Improved scaling of ImageView bitmaps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.appcelerator.org/browse/TIMOB-5176
http://jira.appcelerator.org/browse/TIMOB-5177
These two ended up being basically the same thing and were inextricable. Sorry for the two JIRAs in one pull.
Test 5176 by using precisely the test app.js in that item.
For 5177, see testing notes.