Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-15540] Send out row info in tap recognizers #4891

Merged
merged 3 commits into from Nov 1, 2013
Merged

[TIMOB-15540] Send out row info in tap recognizers #4891

merged 3 commits into from Nov 1, 2013

Conversation

vishalduggal
Copy link
Contributor

Test case is in JIRA

@ghost ghost assigned pec1985 Oct 30, 2013

if ([recognizer numberOfTouchesRequired] == 2) {
if ([[self proxy] _hasListeners:@"touchstart"]) {
[[self proxy] fireEvent:@"twofingertap" withObject:event];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Event names don't match

@pec1985
Copy link
Contributor

pec1985 commented Nov 1, 2013

  • The "dblclick" event does not fire
  • The "touchstart" event fires, but not in this function and does not contain all properties
  • The "twofingertap" does not fire either

Cannot merge as is. Please address comments.

@pec1985
Copy link
Contributor

pec1985 commented Nov 1, 2013

Code reviewed and tested. PR APPROVED!

pec1985 added a commit that referenced this pull request Nov 1, 2013
[TIMOB-15540] Send out row info in tap recognizers
@pec1985 pec1985 merged commit a678e40 into tidev:master Nov 1, 2013
@vishalduggal vishalduggal deleted the timob-15540 branch October 27, 2014 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants