[TIMOB-15647] Fixed bug where incremental builds where encryptJS changed... #4905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ged (i.e. deploy type changed) were not properly cleaning up the previous build. [TIMOB-15639] Fixed bug when trying to do an iOS build with an iOS SDK that is installed, but is not compatible with the current Titanium SDK would continue the build anyways. [TIMOB-15645] Fixed bug where --legacy failed due to the Android build templates being moved (and which were converted to EJS templates). [TIMOB-15645] Added hooks around javac so that CLI plugins can modify the arguments such as the classpath. Fixed bug with iOS build where --build-only and --target device would prompt for a device. Fixed bug with iOS build where force rebuild was being triggered based on deploy type changing when it should have been based on encryptJS changing or being set.
… avd-id and avd-skin.
|
Code reviewed and functionally tested for TIMOB-14170 and TIMOB-15639. Request Accepted. |
|
Also tested iOS tickets. Request Accepted. |
ayeung
pushed a commit
that referenced
this pull request
Nov 4, 2013
[TIMOB-15647] Fixed bug where incremental builds where encryptJS changed...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... (i.e. deploy type changed) were not properly cleaning up the previous build.
[TIMOB-15639] Fixed bug when trying to do an iOS build with an iOS SDK that is installed, but is not compatible with the current Titanium SDK would continue the build anyways.
[TIMOB-15645] Fixed bug where --legacy failed due to the Android build templates being moved (and which were converted to EJS templates).
[TIMOB-14170] Added hooks around javac so that CLI plugins can modify the arguments such as the classpath.
Fixed bug with iOS build where --build-only and --target device would prompt for a device.
Fixed bug with iOS build where force rebuild was being triggered based on deploy type changing when it should have been based on encryptJS changing or being set.