TIMOB-15580 add setSubTitle property and method #4908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Document not updated will update after set setsubtitle as property |
| private static final String SHOW_HOME_AS_UP = "showHomeAsUp"; | ||
| private static final String BACKGROUND_IMAGE = "backgroundImage"; | ||
| private static final String TITLE = "title"; | ||
| private static final String LOGO = "logo"; | ||
| private static final String ICON = "icon"; | ||
| private static final String NAVIGATION_MODE = "navigationMode"; | ||
|
|
||
| private static final String SUBTITLE = "subtitle"; |
There was a problem hiding this comment.
Use TiC.PROPERTY_SUBTITLE.
|
What do you mean by "But not work this as property"? If you want get the value of this property, you need to implement a getter. Something like getTitle() in this class. |
ghost
assigned
|
works on it . still actionBar.subtitle = "New sub Title" not working :( after implement |
|
If the property name is "subtitle", the setter should be setSubtitle() and the getter should be getSubtitle(). |
|
will change |
|
Code reviewed and functionally tested. Accepted |
pingwang2011
added a commit
that referenced
this pull request
Dec 10, 2013
…ionBar TIMOB-15580 add setSubTitle property and method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-15580
Working subtitle as method ( actionBar.setSubTitle("New sub Title"); )
But not work this as property . how can I implement this as property ?