Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timob-14940: Android: touchend event not fired if two touches occured #4917

Merged
merged 2 commits into from Nov 7, 2013

Conversation

pingwang2011
Copy link
Contributor

return true;
// Don't fire twofingertap if there is no listener
if (proxy.hierarchyHasListener(TiC.EVENT_TWOFINGERTAP)) {
if (pointersDown == 1) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mergable ifs

@pingwang2011
Copy link
Contributor Author

Updated.

@hieupham007
Copy link
Contributor

First test case in description failed. Tapping with the 2nd finger doesn't change the view back to red. It's still white. Tested with 4.2.x Galaxy Nexus

@pingwang2011
Copy link
Contributor Author

Updated the test case. Ready for FR.

@hieupham007
Copy link
Contributor

Code reviewed and functionally tested. Request accepted

hieupham007 added a commit that referenced this pull request Nov 7, 2013
timob-14940: Android: touchend event not fired if two touches occured
@hieupham007 hieupham007 merged commit d5ebdca into tidev:master Nov 7, 2013
@pingwang2011 pingwang2011 deleted the timob-14940 branch December 3, 2013 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants