Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TIMOB-13427 add title property and add title in doc #4920

Merged

Conversation

bijupmb
Copy link
Contributor

@bijupmb bijupmb commented Nov 6, 2013

@ghost ghost assigned pingwang2011 Nov 18, 2013
@pingwang2011
Copy link
Contributor

This PR only works for ActionBar-styled tabgroup. How about the TabHost-styled tabgroup when setting targetSdkVersion=10?
Need to set the activity title in TiUITabHostGroup.propertyChnaged(), something like
if (key.equals(TiC.PROPERTY_TITLE)) {
Activity activity = proxy.getActivity();
if (activity != null) {
activity.setTitle(TiConvert.toString(newValue));
}
}

{
// TODO Auto-generated method stub
if (key.equals(TiC.PROPERTY_TITLE)) {
actionBar.setTitle((String) newValue);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use TiConvert.toString

@pingwang2011
Copy link
Contributor

Code reviewed. Please address the comments.

@bijupmb
Copy link
Contributor Author

bijupmb commented Nov 19, 2013

works on this

@pingwang2011
Copy link
Contributor

Code reviewed and functionally tested. Accepted

pingwang2011 added a commit that referenced this pull request Dec 2, 2013
…Property

TIMOB-13427 add title property and add title in doc
@pingwang2011 pingwang2011 merged commit 9751878 into tidev:master Dec 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants