[CLI] Versioning #4932
[CLI] Versioning #4932
Conversation
… by tiapp manifest
- should not overload version given in tiapp.ios - make a difference between CFBundleVersion and CFBundleShortVersionString
| } | ||
| plist.CFBundleShortVersionString = plist.CFBundleVersion; | ||
|
|
||
| plist.CFBundleShortVersionString = appc.version.format(this.tiapp.version, 3, 3); |
There was a problem hiding this comment.
Shound't we have another version parameter in tiapp.xml? I opened a JIRA ticket for this: https://jira.appcelerator.org/browse/TIMOB-15415.
I always must change this on Xcode when generating a Archive (for testing purpose).
|
We could but :
I have a sublime text plugin (this is where i actually build for release). This plugin will increment "android:versionCode" and "CFBundleVersion" directly in my tiapp (and i like to commit it!) remember that if your app is version 1.0.0 buildNumber 89 then: |
|
Ah, I didn't know that I could change this value on tiapp.xml by using an iOS property (CFBundleShortVersionString). It resolves all the problems. Thank you! :-) |
| @@ -3035,6 +3035,7 @@ AndroidBuilder.prototype.generateAndroidManifest = function generateAndroidManif | |||
| tiappAndroidManifest = this.tiappAndroidManifest; | |||
|
|
|||
| finalAndroidManifest.__attr__['android:versionName'] = this.tiapp.version || '1'; | |||
| finalAndroidManifest.__attr__['android:versionCode'] = '1'; | |||
There was a problem hiding this comment.
There's no point in doing this. It's already defaulted to zero in the android/templates/build/AndroidManifest.xml file.
|
Is there a ticket for this PR? I'm trying to map this to something in JIRA. |
|
A related ticket, though not directly addressed by this PR, is https://jira.appcelerator.org/browse/TIMOB-17993 |
|
Closing this PR in favor of #6408 |
Globally fixes app versioning on ios and android: