Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-10415] [TIMOB-7959] [TIMOB-8085] calendar suite made common #4944

Merged
merged 5 commits into from Mar 5, 2014

Conversation

jithinv
Copy link
Contributor

@jithinv jithinv commented Nov 11, 2013

Test cases:
TIMOB-10415
TIMOB-7959
TIMOB-8085

@lokeshchdhry
Copy link
Contributor

Running the tests gives me following errors on IOS:
moduleReachable - 1ms - error - 24
eventLocation - 0ms - exception - 60
noSuchColumnError - 0ms - exception - 68

@lokeshchdhry
Copy link
Contributor

Also, please remind me why have you commented out "eventsBetweenTwoDates" test

@jithinv
Copy link
Contributor Author

jithinv commented Feb 20, 2014

we can't get any calendars in iOS. Please check the following code to get the list of available calendars in iOS.

function showCalendars(calendars) {
for (var i = 0; i < calendars.length; i++) {
Ti.API.info(calendars[i].name);
}
}

Ti.API.info('ALL CALENDARS:');
showCalendars(Ti.Calendar.allCalendars);
if (Ti.Platform.osname === 'android') {
Ti.API.info('SELECTABLE CALENDARS:');
showCalendars(Ti.Calendar.selectableCalendars);
}
This issue was not occurring in the previous Titanium SDK and iOS 6.1

@ingo
Copy link
Contributor

ingo commented Feb 24, 2014

Any updates here on merging this?

@lokeshchdhry
Copy link
Contributor

@jithinv - When you ran this code did it ask for permissions to access the calendars on the phone ?

@jithinv
Copy link
Contributor Author

jithinv commented Feb 25, 2014

we have already setup permissions in tiapp.xml .

@lokeshchdhry
Copy link
Contributor

@jithinv -- please remove the two test which throw the exceptions, eventLocation & noSuchColumnError .
I remember sabil had commented in some of the PR that calendar has to be manually tested on IOS & not through anvil. We will test this manually.

@lokeshchdhry
Copy link
Contributor

Necessary tests removed. Code checked for any changes. Functional tests passes.
Merging.

lokeshchdhry pushed a commit that referenced this pull request Mar 5, 2014
[TIMOB-10415] [TIMOB-7959] [TIMOB-8085] calendar suite made common
@lokeshchdhry lokeshchdhry merged commit 0fd7dd1 into tidev:master Mar 5, 2014
farfromrefug pushed a commit to Akylas/titanium_mobile that referenced this pull request Aug 15, 2014
[TIMOB-10415] [TIMOB-7959] [TIMOB-8085] calendar suite made common
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants