[TIMOB-13000] Fixed load event on image view #4996
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Load event was not working if the image view had touchEnabled set to false
ghost
assigned 
| @@ -1649,7 +1649,7 @@ -(void)fireEvent:(NSString*)type withObject:(id)obj propagate:(BOOL)propagate re | |||
| // Have to handle the situation in which the proxy's view might be nil... like, for example, | |||
| // with table rows. Automagically assume any nil view we're firing an event for is A-OK. | |||
| // NOTE: We want to fire postlayout events on ANY view, even those which do not allow interactions. | |||
| if (proxyView == nil || [proxyView interactionEnabled] || [type isEqualToString:@"postlayout"]) { | |||
| if (proxyView == nil || [proxyView interactionEnabled] || [type isEqualToString:@"postlayout"] || [type isEqualToString:@"load"]) { | |||
There was a problem hiding this comment.
This will work but I would prefer more scalable code.
Define a method in TiViewProxy which returns an array of state events.
By default it will return postlayout.
ImageView will return postlayout and load.
Then you can check if state array contains event type and we can just modify that array for our proxies
| { | ||
| NSMutableArray *arr = [NSMutableArray array]; | ||
| [arr addObject:@"postlayout"]; | ||
| if([self isKindOfClass:[TiUIImageViewProxy class]]) { |
There was a problem hiding this comment.
This check should not be here. Instead the TiUIImageViewProxy class must override the method to return a different array
|
Code reviewed. Please address comments |
|
Comments addressed. |
|
Closing per #6630 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load event was not working if the image view had touchEnabled set to false