Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-15785]IOS: Fixing Remote Push broken due to silent push. #5008

Merged
merged 2 commits into from Nov 22, 2013

Conversation

srahim
Copy link
Contributor

@srahim srahim commented Nov 22, 2013

Testing Instruction

  1. Try sending a normal remote push while the app is in the background. - Remote push callback should fire.
  2. Try build a app without include UIBackgroundModes - fetch or remote-notification in backgroundmodes.
    **Check the build apps defines.h to verify that defines.h does not contain #define USE_TI_SILENTPUSH or #define USE_TI_FETCH inside it.
  3. Repeat step number 2 including the modes. and the defines should show up.

@cb1kenobi
Copy link
Contributor

Code reviewed the iOS build changes. APPROVED.

@pec1985
Copy link
Contributor

pec1985 commented Nov 22, 2013

CLI Function review passed.

pec1985 added a commit that referenced this pull request Nov 22, 2013
[TIMOB-15785]IOS: Fixing Remote Push broken due to silent push.
@pec1985 pec1985 merged commit b867cbe into tidev:master Nov 22, 2013
@srahim srahim deleted the timob-15785 branch December 10, 2013 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants