Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TC-3386] Fixes incorrect layout of error screen when in device is in landscape. #5106

Closed
wants to merge 3 commits into from

Conversation

dbankier
Copy link
Contributor

No description provided.

@pec1985
Copy link
Contributor

pec1985 commented Dec 10, 2013

Spaces are a bit off. For tab use 4 spaces (I think you already are). Then, place a space after ] if it contains another function call (not a dot). Also, remove space after (

@pec1985
Copy link
Contributor

pec1985 commented Dec 10, 2013

Add test sample code in Jira as well, something we can copy and paste into an app.js

@ghost ghost assigned pec1985 Dec 10, 2013
@dbankier
Copy link
Contributor Author

hey @pec1985, happy to reformat which ever way you like. The file itself uses tab instead of spaces throughout. Do you want me to reformat that whole file?

@pec1985
Copy link
Contributor

pec1985 commented Dec 18, 2013

Hi David, yes, we use 4 spaces. Apologies for not responding earlier, I just saw your response.

@dbankier
Copy link
Contributor Author

ok done - reformatted the whole file

@pec1985
Copy link
Contributor

pec1985 commented Dec 20, 2013

Tested the PR and it works. There's a minor layout issue, see attached.:
screen shot 2013-12-20 at 12 57 32 pm

@ingo
Copy link
Contributor

ingo commented Feb 13, 2014

@dbankier Are you able to correct the layout issue?

@dbankier
Copy link
Contributor Author

done.

@pec1985
Copy link
Contributor

pec1985 commented Feb 14, 2014

It's getting better, but still off.
screen shot 2014-02-14 at 4 10 43 am

@pec1985
Copy link
Contributor

pec1985 commented Feb 14, 2014

@dbankier, have you played around with iOS Auto Layout engine? it's pretty cool, could be applied here, and it's not too hard to implement. Take a look at this gist: https://gist.github.com/pec1985/9006628

@dbankier
Copy link
Contributor Author

I think you rotated after the error came up. I don't have any time now to make further changes. (It works fine as is for my purposes.)

@pec1985
Copy link
Contributor

pec1985 commented Mar 4, 2014

New PR #5418

@pec1985 pec1985 closed this Mar 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants