[TIMOB-16004] iOS: Expose current file path and directory path to commonjs module scope. #5131
Conversation
|
@euforic could you please submit a PR which includes the changes thats only required and not whitespace changes. it would be easier to find the changes you made, so that something important is not missed in CR |
| tempString =[tempString stringByReplacingOccurrencesOfString:@""" withString:@"\""]; | ||
|
|
||
| NSString *directory = [[[sourceURL absoluteString] stringByDeletingLastPathComponent] tringByReplacingOccurrencesOfString:@"file:/" withString:@"file:///"]; | ||
| NSString *filename = [[[sourceURL absoluteString] lastPathComponent] tringByReplacingOccurrencesOfString:@"file:/" withString:@"file:///"]; |
There was a problem hiding this comment.
tringByReplacingOccurrencesOfString: should be stringByReplacingOccurrencesOfString
did you try building this ?
|
@srahim sorry I was working from a live build and then copied my changes to the repo. I fixed both issues with the PR |
|
@srahim any updates on this ? |
|
@euforic. Can you please fix the whitespace? |
|
@euforic could you remove all the whitespace changes. i think everything else looks good. |
…monjs module scope.
|
@srahim Fixed |
|
@srahim any updates on this ? |
|
Code reviewed and tested. PR REJECTED! |
|
Closing PR, duplicate: #5641 |
[TIMOB-16004] iOS: Expose current file path and directory path to commonjs module scope.