[TIMOB-16088] Removed WRITE_EXTERNALSTORAGE permission for production an... #5172
Conversation
… and non-debug test builds. Only add the TiAnalyticsService if analytics is enabled. Added plugin hook for when AndroidManifest.xml is written.
|
Just to confirm, a user could add this permission back manually if they wanted it, yes? Did we always add it before in 3.1.X builds so now a user might be confused where it went? |
|
@ingo Yes, to add it back, then can simply make a custom AndroidManifest.xml that includes it. They could also write a hook that adds it, but that would be more work. It appears that it was always there in 3.1.x, however I have not confirmed this. Even if it was added by default in 3.1.x, it's possible that it is not added when using a custom AndroidManifest.xml. That would require some testing. |
|
I would be concerned that we not cause additional confusion by removing a permission that was there by default. We should confirm the old behavior and make sure the new behavior changes as little as possible. |
…onfig option to merge custom AndroidManifest.xml to preserve 3.2.0 behavior, but it is disabled by default. Updated i18n strings.
|
Code reviewed and functionally tested. Request Accepted. |
[TIMOB-16088] Removed WRITE_EXTERNALSTORAGE permission for production an...
...d non-debug test builds. Only add the TiAnalyticsService if analytics is enabled. Added plugin hook for when AndroidManifest.xml is written.