[TIMOB-16088] Removed WRITE_EXTERNALSTORAGE permission for production an... #5173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and non-debug test builds. Only add the TiAnalyticsService if analytics is enabled. Added plugin hook for when AndroidManifest.xml is written.
…onfig option to merge custom AndroidManifest.xml to preserve 3.2.0 behavior, but it is disabled by default. Updated i18n strings.
|
Code reviewed and functionally tested. Request Accepted. |
ayeung
pushed a commit
that referenced
this pull request
Jan 3, 2014
[TIMOB-16088] Removed WRITE_EXTERNALSTORAGE permission for production an...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...d non-debug test builds. Only add the TiAnalyticsService if analytics is enabled. Added plugin hook for when AndroidManifest.xml is written.