New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-14007] set font property #5198
[TIMOB-14007] set font property #5198
Conversation
@@ -147,6 +150,10 @@ public void processProperties(KrollDict d) { | |||
numericMonths = TiConvert.toBoolean(d, "numericMonths"); | |||
} | |||
|
|||
if (d.containsKeyStartingWith("font")) { | |||
setFontProperties(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation
Code reviewed. Please address comments. |
will check it |
String fontWeight = null; | ||
Typeface typeface = null; | ||
KrollDict d = proxy.getProperties(); | ||
// KrollDict d = new KrollDict(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove unused code
Code reviewed. Please address comments. |
@hieupham007 Your review comments were addressed over 2 weeks ago. Please review the PR and bring it to a closure. |
Already modified |
@hieupham007 - Please review this PR. |
Code reviewed and functionally tested. Request accepted |
…tyForPickerAndPickerColmn [TIMOB-14007] set font property
…ropertyForPickerAndPickerColmn [TIMOB-14007] set font property
https://jira.appcelerator.org/browse/TIMOB-14007