[TIMOB-5996] add removeview function #5235
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The ticket suggests that the problem is for ScrollableView, not ScrollView. Your fix is for ScrollView. Please do this for ScrollableView, update the test case and documentation. |
|
Code reviewed. Please address comments. |
|
ok. will correct it |
|
@hieupham007 Your comments were addressed over a month ago. Please review this PR and bring it to a closure. |
|
Already modified |
|
@hieupham007 - Please review this PR. |
| public void removeView(Object viewObject) | ||
| { | ||
| TiMessenger.sendBlockingMainMessage(getMainHandler().obtainMessage(MSG_REMOVE_VIEW), viewObject); | ||
| public void removeView(Object viewObject) { |
There was a problem hiding this comment.
This implementation is on the wrong thread. Please do this on the main thread via messaging. See MSG_REMOVE_VIEW for more details.
|
Code reviewed. Please address comments |
|
ok start working |
|
@hieupham007 Can you review the code changes please |
|
Closing PR. Does not work as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-5996