[TIMOB-16207] parse string to boolean #5238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -386,7 +386,7 @@ public boolean onEditorAction(TextView v, int actionId, KeyEvent keyEvent) | |||
| fireEvent(TiC.EVENT_RETURN, data); | |||
| } | |||
|
|
|||
| Boolean enableReturnKey = (Boolean) proxy.getProperty(TiC.PROPERTY_ENABLE_RETURN_KEY); | |||
| Boolean enableReturnKey = Boolean.parseBoolean(proxy.getProperty(TiC.PROPERTY_ENABLE_RETURN_KEY).toString()); | |||
There was a problem hiding this comment.
Use TiConvert.toBoolean().
…e into TIMOB-16207-BooleanToaStringThrowsClassCastException
| @@ -386,7 +386,7 @@ public boolean onEditorAction(TextView v, int actionId, KeyEvent keyEvent) | |||
| fireEvent(TiC.EVENT_RETURN, data); | |||
| } | |||
|
|
|||
| Boolean enableReturnKey = (Boolean) proxy.getProperty(TiC.PROPERTY_ENABLE_RETURN_KEY); | |||
| Boolean enableReturnKey = TiConvert.toBoolean(proxy.getProperty(TiC.PROPERTY_ENABLE_RETURN_KEY).toString()); | |||
There was a problem hiding this comment.
You don't need to call .toString(), ToConvert.toBoolean will do it for you. Simply call TiConvert.toBoolean(proxy.getProperty(TiC.PROPERTY_ENABLE_RETURN_KEY));
|
Code reviewed. Please address comments |
|
Code reviewed and functionally tested. Request accepted |
hieupham007
added a commit
that referenced
this pull request
Mar 6, 2014
…owsClassCastException [TIMOB-16207] parse string to boolean
farfromrefug
pushed a commit
to Akylas/titanium_mobile
that referenced
this pull request
Aug 15, 2014
…ngThrowsClassCastException [TIMOB-16207] parse string to boolean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-16207