Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-14069] changes in keyboard type checking function #5252

Closed
wants to merge 2 commits into from
Closed

[TIMOB-14069] changes in keyboard type checking function #5252

wants to merge 2 commits into from

Conversation

bijupmb
Copy link
Contributor

@bijupmb bijupmb commented Jan 24, 2014

@hieupham007
Copy link
Contributor

I'm still not seeing the decimal pad with this change. FR failed. Please look at the doc for expected behavior: http://docs.appcelerator.com/titanium/latest/#!/api/Titanium.UI-property-KEYBOARD_DECIMAL_PAD

@hieupham007
Copy link
Contributor

Code reviewed. Please address comments

@hieupham007
Copy link
Contributor

Any update on this?

@bijupmb
Copy link
Contributor Author

bijupmb commented Apr 1, 2014

will check

@negupta
Copy link
Contributor

negupta commented Apr 17, 2014

@bijupmb There has been no update on this PR for over 2 weeks now. We should follow up proactively on these PR comments.

@bijupmb
Copy link
Contributor Author

bijupmb commented Apr 18, 2014

Problem is in onlayoutChange method in TiTableView I am looking into it

@bijupmb
Copy link
Contributor Author

bijupmb commented Apr 24, 2014

Done the changes

@negupta
Copy link
Contributor

negupta commented Apr 28, 2014

@hieupham007 - Please review the PR.

@hieupham007
Copy link
Contributor

Functional test failed. Unable to type anything in textfield.

@bijupmb
Copy link
Contributor Author

bijupmb commented May 1, 2014

I can type number values in textfield. Let me test more devices

@hieupham007
Copy link
Contributor

PR doesn't fix problem ,closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bijupmb @hieupham007 @negupta