[TIMOB-15099] use default unit for border radius #5310
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please extend this to borderWidth as well. |
|
borderWidth is already taken care of. |
| * @param parent the parent view used for calculation. | ||
| * @return the number of pixels. | ||
| */ | ||
| public double getPixelsRaw(View parent) |
There was a problem hiding this comment.
This method is a duplicate of getPixels(View parent). Couldn't we have just just made that method public?
|
Changes are also required to the method |
|
Code Reviewed. Please address comments |
|
New PR 5521. Closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the default unit for radius.
https://jira.appcelerator.org/browse/TIMOB-15099