[TIMOB-16320] Android: Integrate v7 compat library #5314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
git is ignoring empty folders. i.e: Titanium_Mobile/android/modules/appcompat/src/java. When I create that folder manually, it works fine. |
|
Changes pushed. Ready for review |
|
Code reviewed and functionally tested. Request accepted |
hieupham007
added a commit
that referenced
this pull request
Feb 6, 2014
[TIMOB-16320] Android: Integrate v7 compat library
|
Hi, How do i install this? I currently have 3.2.2.GA SDK but when I do custom theme for Android, it doesn't work cos android support lib v7 is not installed. Please can you advise? |
|
http://builds.appcelerator.com/#master. Download the latest build. You have to be using 3.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves TIMOB-16320 and unblocks us from continuing work on TIMOB-15021
This essentially loads v7-appcompat library as a module in the titanium SDK. Also removes a bunch of unrequired resources and puts the hooks in to build namespace specific resources.
This PR has an ugly hack to get the appcompat library to be included (see update to KrollAPIUpdater.java) which should be revisited by us when we work on TIMOB-11360.
For testing just build the SDK and run any titanium app. There should be no change in functionality. This PR does not change the build scripts to generate new themes based on the AppCompat library. That will be done as part of TIMOB-15021.