[TIMOB-15888] Use scaleDetector only if PINCH event needs to be handled #5345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't reproduce this on master and 3.2.2.GA. |
|
Try with https://maps.google.com. The pinch zoom is very jittery. it sometimes works and sometimes doesn't. |
|
Code reviewed and functionally tested. Request accepted |
hieupham007
added a commit
that referenced
this pull request
Apr 8, 2014
[TIMOB-15888] Use scaleDetector only if PINCH event needs to be handled
farfromrefug
pushed a commit
to Akylas/titanium_mobile
that referenced
this pull request
Aug 15, 2014
[TIMOB-15888] Use scaleDetector only if PINCH event needs to be handled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use scaleDetector only if PINCH event needs to be handled as it interfere with the WebView pinch zoom.
https://jira.appcelerator.org/browse/TIMOB-15888